Restructured CodeBehindGenerator pipeline #20524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hability - Split out CSS SourceGen, which does not depend on Compilation at all - Added TrackingNames to support new SourceGen unit test project Fixes Issue #12978 CodeBehindGenerator has improper pipeline Fixes AB#1947659: `CodeBehindGenerator` has improper pipeline
StephaneDelcroix
previously approved these changes
Feb 13, 2024
MartyIX
reviewed
Feb 13, 2024
Comment on lines
21
to
26
| $@" | ||
| h1 {{color: purple; | ||
| background-color: lightcyan; | ||
| font-weight: 800; | ||
| }} | ||
| "; |
There was a problem hiding this comment.
Would it be good to use raw-string literals?
MartyIX
reviewed
Feb 13, 2024
| @@ -0,0 +1,16 @@ | |||
| namespace Microsoft.Maui.Controls.SourceGen | |||
There was a problem hiding this comment.
Maybe file-scoped namespace would lead to unified code with the rest of PR
jsuarezruiz
previously approved these changes
Feb 13, 2024
- Use raw string literals for SourceGen tests
mgoertz-msft
dismissed stale reviews from jsuarezruiz and StephaneDelcroix
via
b5816eb
StephaneDelcroix
approved these changes
Feb 20, 2024
rmarinho
pushed a commit
that referenced
this pull request
Feb 27, 2024
* - Restructured CodeBehindGenerator pipeline to maximize SourceGen cachability - Split out CSS SourceGen, which does not depend on Compilation at all - Added TrackingNames to support new SourceGen unit test project Fixes Issue #12978 CodeBehindGenerator has improper pipeline Fixes AB#1947659: `CodeBehindGenerator` has improper pipeline * - Use file-scoped namespaces throughout PR - Use raw string literals for SourceGen tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Before:
stateDiagram-v2 classDef noisyState fill:red,color:white,font-weight:bold AdditionalTextsProvider --> ProjectItemProvider AnalyzerConfigOptionsProvider --> ProjectItemProvider CompilationProvider --> XmlnsDefinitionsProvider:::noisyState CompilationProvider --> ReferenceTypeCacheProvider:::noisyState ProjectItemProvider --> SourceProvider XmlnsDefinitionsProvider --> SourceProvider ReferenceTypeCacheProvider --> SourceProvider CompilationProvider:::noisyState --> SourceProvider SourceProvider:::noisyState --> [*] : for Xaml and Css note left of CompilationProvider Changes constantly! end noteAfter:
stateDiagram-v2 classDef noisyState fill:red,color:white,font-weight:bold AdditionalTextsProvider --> ProjectItemProvider AnalyzerConfigOptionsProvider --> ProjectItemProvider ProjectItemProvider --> CssProjectItemProvider : where Kind == CSS CssProjectItemProvider --> CssSourceProvider CssSourceProvider --> [*] ProjectItemProvider --> XamlProjectItemProvider : where Kind == XAML CompilationProvider:::noisyState --> ReferenceCompilationProvider : with CompilationReferencesComparer ReferenceCompilationProvider --> XmlnsDefinitionsProvider ReferenceCompilationProvider --> ReferenceTypeCacheProvider XamlProjectItemProvider --> XamlSourceProvider XmlnsDefinitionsProvider --> XamlSourceProvider ReferenceTypeCacheProvider --> XamlSourceProvider ReferenceCompilationProvider --> XamlSourceProvider XamlSourceProvider --> [*] note left of CompilationProvider Changes constantly! end note note right of ReferenceCompilationProvider Rarely changes end noteIssues Fixed
CodeBehindGeneratorhas improper pipeline #12978CodeBehindGeneratorhas improper pipeline